Repository navigation
Refactor: marker question and --config ask through one Terminal seam - #21
Merged
Merged
Conversation
main(argv, terminal=...) takes the person running the command. Tests hand it a FakeTerminal with scripted replies (or none, the way an agent runs) instead of monkeypatching sys.stdin.isatty and builtins.input. EOF at the marker question is now a clean refusal rather than a traceback; nothing is sent either way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC
|
Review of the
Nits, non-blocking:
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marker order is unchanged: flag → contacts.toml setting → ask the person → refuse.
Evidence
main()aFakeTerminal(["n"]), orFakeTerminal(None)for an agent. They no longer monkeypatchisatty/input. An autouse fixture makes every test agent-like by default, so nothing reads the real stdin.test_a_person_at_the_terminal_can_decline_the_marker(red → green).test_a_person_who_ends_input_at_the_marker_question_sends_nothing. Mutation-checked: making no-answer count as yes fails it.Merge Danger
Door: two-way
Blast Radius: none
🤖 Generated with Claude Code
https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC